platform: xuantie: Harden xuantie link pmu init#10
Merged
Conversation
Several robustness fixes in xuantie_link_pmu_device_init(): - Use `>= 0` to validate fdt_node_offset_by_compatible() result; the previous `> 0` check would miss a node at offset 0. - Iterate all instances of each PMU compatible instead of only the first one, so multi-cluster SoCs initialise every L3 PMU. - Skip nodes with status = "disabled" via fdt_node_is_enabled(). - Default-inhibit all counters (matches the kernel driver probe behaviour) so counters do not free-run between OpenSBI and kernel handoff. - Replace magic numbers with named macros (CNT_BITMAP, AUTHCR_AUTH, AUTHCR_INTPEND). - Bail out early if fdt_get_address_rw() returns NULL. Signed-off-by: Chen Pei <cp0613@linux.alibaba.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several robustness fixes in xuantie_link_pmu_device_init():
>= 0to validate fdt_node_offset_by_compatible() result; the previous> 0check would miss a node at offset 0.