fix: improve error message when entity repeat doesn't exist (fixes #784)#792
Closed
Anuragkrosuru wants to merge 1 commit intoXLSForm:masterfrom
Closed
fix: improve error message when entity repeat doesn't exist (fixes #784)#792Anuragkrosuru wants to merge 1 commit intoXLSForm:masterfrom
Anuragkrosuru wants to merge 1 commit intoXLSForm:masterfrom
Conversation
Author
|
I've created PR #792 to address this issue. The PR adds validation to check if the entity repeat exists in the survey and provides a clearer error message pointing to the entities sheet. |
Contributor
|
Thanks for your interest in this issue, @Anuragkrosuru! We're going to revisit the implementation in light of #800 so I'm going to close this for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #784
Why is this the best possible solution? Were any other approaches considered?
What are the regression risks?
Does this change require updates to documentation? If so, please file an issue here and include the link below.
Before submitting this PR, please make sure you have:
testspython -m unittestand verified all tests passruff format pyxform testsandruff check pyxform teststo lint code