Skip to content

[Need more test] fix: skip population identity transactions in bot mode - #29

Merged
XBribo merged 1 commit into
XBribo:mainfrom
xiaoyueyoqwq:fix/native-bot-population-transaction
Aug 29, 2026
Merged

[Need more test] fix: skip population identity transactions in bot mode#29
XBribo merged 1 commit into
XBribo:mainfrom
xiaoyueyoqwq:fix/native-bot-population-transaction

Conversation

@xiaoyueyoqwq

@xiaoyueyoqwq xiaoyueyoqwq commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Need more test

This PR prevents unnecessary BotHider identity transactions when identity_mode=bot is active. Valve retains full control of native bot population and team-management operations.

Change

  • Skip population transactions around bot_add/bot_kick commands in native bot mode.
  • Bypass the MaintainBotQuota, human-team restriction, and managed join-team identity transactions in native bot mode.
  • Keep identity_mode=player behavior unchanged.

Rationale

Native bot mode already exposes Valve's authoritative fake-client identity. Snapshotting and rewriting those clients is unnecessary and can touch a controller while it is being created, rejected, or destroyed. Avoiding these writes narrows BotHider's interaction with engine-owned population state.

Validation

  • Linux CMake build passed.
  • BotHiderImpl/BotHiderApi Release build passed with 0 warnings and 0 errors.
  • git diff --check passed.
  • Runtime validation is still required.

Required review/test

Please test native bot population operations with identity_mode=bot, including successful and rejected bot creation, bot removal, team changes, map transitions, and repeated population updates. Confirm that names, SteamIDs, avatars, fake ping, IsBot compatibility, team restrictions, quota maintenance, and teardown behavior remain correct.

Potential behavior impact is intentionally unverified: native bot mode no longer receives BotHider's temporary identity restoration around population/team calls. The change is intended to preserve native engine behavior, but requires additional server-side review before merge.

@XBribo

XBribo commented Aug 29, 2026

Copy link
Copy Markdown
Owner

That's really helpful, thank you!

@XBribo
XBribo merged commit 75a3c3b into XBribo:main Aug 29, 2026
@xiaoyueyoqwq
xiaoyueyoqwq deleted the fix/native-bot-population-transaction branch August 29, 2026 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants