[Need more test] fix: skip population identity transactions in bot mode - #29
Merged
XBribo merged 1 commit intoAug 29, 2026
Merged
Conversation
Owner
|
That's really helpful, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need more test
This PR prevents unnecessary BotHider identity transactions when
identity_mode=botis active. Valve retains full control of native bot population and team-management operations.Change
bot_add/bot_kickcommands in native bot mode.MaintainBotQuota, human-team restriction, and managed join-team identity transactions in native bot mode.identity_mode=playerbehavior unchanged.Rationale
Native bot mode already exposes Valve's authoritative fake-client identity. Snapshotting and rewriting those clients is unnecessary and can touch a controller while it is being created, rejected, or destroyed. Avoiding these writes narrows BotHider's interaction with engine-owned population state.
Validation
git diff --checkpassed.Required review/test
Please test native bot population operations with
identity_mode=bot, including successful and rejected bot creation, bot removal, team changes, map transitions, and repeated population updates. Confirm that names, SteamIDs, avatars, fake ping,IsBotcompatibility, team restrictions, quota maintenance, and teardown behavior remain correct.Potential behavior impact is intentionally unverified: native bot mode no longer receives BotHider's temporary identity restoration around population/team calls. The change is intended to preserve native engine behavior, but requires additional server-side review before merge.