Skip to content

Tests: Add unit tests for get_author_posts_url() - #14406

Closed
shail-mehta wants to merge 1 commit into
WordPress:trunkfrom
shail-mehta:65819-add-get-author-posts-url-tests
Closed

shail-mehta wants to merge 1 commit into
WordPress:trunkfrom
shail-mehta:65819-add-get-author-posts-url-tests

Conversation

@shail-mehta

Copy link
Copy Markdown
Member

What

Trac ticket: #65819

Adds unit tests for get_author_posts_url() in tests/phpunit/tests/user/getAuthorPostsUrl.php.

Why

get_author_posts_url() currently has no dedicated @covers unit test file.

How

Adds Tests_User_GetAuthorPostsUrl to test returning a query-string author URL without pretty permalinks, returning a pretty author permalink and looking up the author nicename when omitted, and applying the author_link filter.

Testing Instructions

npm run test:php -- --filter Tests_User_GetAuthorPostsUrl

Use of AI Tools

  • Cursor

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused tests match existing behavior and use the test framework’s cleanup mechanisms, with no unresolved findings.

No open issues 🎉

What changed in this PR

Adds dedicated unit coverage for get_author_posts_url() without changing production code.

Changes:

  • Tests query-string and pretty author URLs.
  • Checks nicename lookup and explicit nicename handling.
  • Verifies author_link filter arguments and its returned URL.
File Description
tests/​phpunit/​tests/​user/​getAuthorPostsUrl.php Adds author URL tests with a shared author fixture.

Review effort: Balanced

@shail-mehta
shail-mehta marked this pull request as ready for review October 17, 2026 09:43
@github-actions

github-actions Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props shailu25, rejaulalomkhan.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@rejaulalomkhan

Copy link
Copy Markdown

@shail-mehta Thanks for working on this PR

@lancewillett lancewillett left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the tests against the implementation and existing coverage, including the unit-tests audit. No blocking findings. The affected classes passed locally in randomized order on single site (3 tests) and multisite (3 tests); PHPCS and current CI pass.

AI review · gpt-6

wporg-sync pushed a commit that referenced this pull request Oct 17, 2026
Checks query-string and pretty author URLs, explicit nicenames, and the author-link filter arguments.

Developed in: #14406

Props shailu25, rejaulalomkhan.
See #65819.


git-svn-id: https://develop.svn.wordpress.org/trunk@64482 602fd350-edb4-49c9-b593-d223f7449a82
@lancewillett

Copy link
Copy Markdown
Member

wporg-sync pushed a commit to WordPress/WordPress that referenced this pull request Oct 17, 2026
Checks query-string and pretty author URLs, explicit nicenames, and the author-link filter arguments.

Developed in: WordPress/wordpress-develop#14406

Props shailu25, rejaulalomkhan.
See #65819.

Built from https://develop.svn.wordpress.org/trunk@64482


git-svn-id: http://core.svn.wordpress.org/trunk@63632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants