Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The implementation matches the stated migration and includes comprehensive coverage for compatibility, errors, Unicode, and built-in YAML features.
0 open findings
What changed in this PR
Replaces custom YAML parsing/serialization with Wolfram Language 15.0 built-ins while preserving error handling and Unicode behavior.
Changes:
- Uses built-in YAML import/export with explicit UTF-8 conversion for strings.
- Simplifies YAML parse errors and removes custom parser code.
- Updates and expands YAML and generated-skill tests.
| File | Description |
|---|---|
Kernel/YAML.wl |
Implements built-in YAML handling. |
Kernel/Messages.wl |
Simplifies YAML parse errors. |
Kernel/AgentSkills.wl |
Updates parser documentation. |
Tests/YAML.wlt |
Updates expectations and adds feature coverage. |
Tests/InstallMCPServer.wlt |
Updates generated YAML expectations. |
Tests/DeployAgentToolsSkills.wlt |
Updates skill frontmatter expectations. |
Tests/AgentSkills.wlt |
Updates generated skill snapshots. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation