fix(exports): drop broken bun condition pointing at unshipped src/ — v6.7.2#73
Merged
Merged
Conversation
…— v6.7.2 Bun's resolver always picks the `bun` exports condition first → fails to find `./src/index.ts` (not in the published tarball) → all downstream bun-test consumers crash at module-load. Node is unaffected (ignores the `bun` condition). Removed the line; bun now falls through to `default` → `dist/index.js`, same compiled JS Node was already loading. No internal use of the condition either (faf-cli's `dev` script invokes `bun src/cli.ts` directly by path). Downstream impact: removes the need for the `src/utils/faf-cli-bridge.ts` workaround in faf-mcp 2.1.1 + claude-faf-mcp 5.6.1 + (incoming) grok-faf-mcp 1.4.1. Once faf-mcp/claude/grok bump to ^6.7.2, the bridge files can be removed in follow-up PRs. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
bunexports condition that pointed at./src/index.ts(not in the published tarball). Bun consumers couldn't resolvefrom 'faf-cli'against the tarball; Node was unaffected. Now both runtimes resolve todist/index.js.Downstream impact: unblocks dropping the
src/utils/faf-cli-bridge.tsworkaround from faf-mcp 2.1.1 + claude-faf-mcp 5.6.1 + (incoming) grok-faf-mcp 1.4.1. Bridge-removal PRs to follow once those repos bump to ^6.7.2.Smoke-tested: bun import resolves cleanly,
scoreFafYamlis a function.Tests: 748/0 (was 748/0). tsc clean.