conn: fix IPv6 address corruption in StdNetBind.Send()#135
Open
mp2720 wants to merge 1 commit intoWireGuard:masterfrom
Open
conn: fix IPv6 address corruption in StdNetBind.Send()#135mp2720 wants to merge 1 commit intoWireGuard:masterfrom
mp2720 wants to merge 1 commit intoWireGuard:masterfrom
Conversation
Ensure the IP slice is properly sized before copying address bytes when reusing objects from the udpAddrPool. Previously, copying before resizing could truncate IPv6 addresses and leave leftover bytes from previous uses, causing datagrams to be sent to incorrect addresses. Signed-off-by: Salomakhin Timur <mp2720@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure the IP slice is properly sized before copying address bytes when reusing objects from the udpAddrPool. Previously, copying before resizing could truncate IPv6 addresses and leave leftover bytes from previous uses, causing datagrams to be sent to incorrect addresses.
The bug is easily reproducible in a configuration where both v6 and v4 endpoints are used.
This change also fixes the "not too sticky" test (but others from
tests/netns.shstill seem to be broken).