Skip to content

Conversation

@camillobruni
Copy link
Contributor

@camillobruni camillobruni commented Dec 10, 2025

Similar to ShellFileLoader introduce a BrowserFileLoader as mid-term solution to clean up the file loading code.

  • Move common helpers and caches from the driver to the BrowserFileLoader.
  • Pass along a "counter" param where easily possible

@netlify
Copy link

netlify bot commented Dec 10, 2025

Deploy Preview for webkit-jetstream-preview ready!

Name Link
🔨 Latest commit f6177c4
🔍 Latest deploy log https://app.netlify.com/projects/webkit-jetstream-preview/deploys/695d1f06d3d1e200086f5b04
😎 Deploy Preview https://deploy-preview-242--webkit-jetstream-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@camillobruni
Copy link
Contributor Author

Mid to long term I want to fix:

  • Loading the same resource as file and and preload (see js-token js-tokens: use preload source code #228 PR that is currently blocked on this)
  • Clean up retry loading (I have a hunch that we can remove it but I'm not 100% certain)
  • Merge more shell and browser file loading code

Copy link
Contributor

@kmiller68 kmiller68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall seems fine. I'm a bit mid on the counter passing since it's not fixed everywhere so it's in a weird in-between half global / half parameter state. IMO we should pick one or the other and stick with it or fix it everywhere but I'm not gonna block on it.

@camillobruni
Copy link
Contributor Author

I agreed :) I will keep on refactoring a bit in follow up PRs so we can see which way works better (likely local)

@camillobruni camillobruni merged commit 53cefcd into WebKit:main Jan 6, 2026
23 checks passed
@camillobruni camillobruni deleted the 2025-12-10_resources branch January 6, 2026 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants