Make make_absolute thread-local in chdir.c#781
Open
CPunisher wants to merge 2 commits intoWebAssembly:mainfrom
Open
Make make_absolute thread-local in chdir.c#781CPunisher wants to merge 2 commits intoWebAssembly:mainfrom
make_absolute thread-local in chdir.c#781CPunisher wants to merge 2 commits intoWebAssembly:mainfrom
Conversation
Collaborator
|
Thanks for the PR! I think though this might be something that's more appropriate to use synchronization for rather than thread-local storage. These are malloc'd buffers which means that if it were thread-local then a thread exiting would leak the buffer information. As a |
Author
|
I've updated the code to use synchronization instead of thread-local storage. I ended up protecting the whole |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make_absolutepreviously used a process-wide static buffer to assemble absolute paths for relative path resolution. In_REENTRANTbuilds, concurrent calls could overwrite or reallocate that shared buffer while another thread was still using it, leading to races and potentially invalid pointers.Related #474