Skip to content

Allow thread.new-indirect to return -1 in case of resource exhaustion #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukewagner merged 1 commit into from
Nov 3, 2026
Merged

Allow thread.new-indirect to return -1 in case of resource exhaustion #760

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion design/mvp/CanonicalABI.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4648,7 +4648,8 @@ Calling `$new_indirect` invokes the following function which reads a `funcref`
from `$ftbl` (trapping if out-of-bounds, null or the wrong type), creates a new
suspended thread that will call the `funcref` passing the closure parameter `$c`
when resumed, and returns the index of the new thread in the current component
instance's `threads` table.
instance's `threads` table. Alternatively, `-1` may be nondeterministically
returned by the host in case of resource exhaustion.
```python
@dataclass
class CoreFuncRef:
Expand All @@ -4661,6 +4662,8 @@ def canon_thread_new_indirect(ft, ftbl: Table[CoreFuncRef], fi, c):
f = ftbl.get(fi)
assert(ft == CoreFuncType(['i32'], []) or ft == CoreFuncType(['i64'], []))
trap_if(f.t != ft)
if not DETERMINISTIC_PROFILE and random.randint(0,1):
return [-1]
def thread_func():
[] = call_and_trap_on_throw(f.callee, [c])
task.unregister_thread(new_thread)
Expand Down
2 changes: 2 additions & 0 deletions design/mvp/canonical-abi/definitions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2609,6 +2609,8 @@ def canon_thread_new_indirect(ft, ftbl: Table[CoreFuncRef], fi, c):
f = ftbl.get(fi)
assert(ft == CoreFuncType(['i32'], []) or ft == CoreFuncType(['i64'], []))
trap_if(f.t != ft)
if not DETERMINISTIC_PROFILE and random.randint(0,1):
return [-1]
def thread_func():
[] = call_and_trap_on_throw(f.callee, [c])
task.unregister_thread(new_thread)
Expand Down
Loading