Make strongly-unique hyphen-insensitive - #704
Open
bvisness wants to merge 1 commit into
Open
Conversation
badeend
approved these changes
Aug 20, 2026
badeend
left a comment
Member
There was a problem hiding this comment.
I think this makes sense and offers wider compatibility across different languages 👍
Member
|
Good point! Makes sense to me. It might be good to get a bit of implementation feedback (to see if this breaks anything) before merging though. |
Collaborator
Author
|
Yeah, for sure. I do think this is a direction we want to go but there's no urgency to merge this; we can work around stuff for now (and are unlikely to encounter this in practice). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #197 @lukewagner discussed making the strongly-unique algorithm also hyphen-insensitive. There was also some discussion of how strong this needed to be, but in my opinion it makes the most sense to remove hyphens entirely when checking for uniqueness, as this completely prevents names that differ only in case.
This is already a concern for us in Firefox, as an identifier like
[method]a-b.ABon resource typea-bwill produce a class namedAB(PascalCase), and a method namedAB(theoretically camelCase, but acronym). That's maybe workable for us as far as JS goes (because the constructor is just namedconstructor), but obviously other languages like Java and C# would choke on this case as well. I don't see a good reason for component interfaces to require case sensitivity.