Skip to content

RCS fixes#615

Merged
dragonmantank merged 6 commits intomainfrom
rcs-fixes
Mar 5, 2026
Merged

RCS fixes#615
dragonmantank merged 6 commits intomainfrom
rcs-fixes

Conversation

@dragonmantank
Copy link
Member

  • Added some missing RCS config data
  • Made TTL public so it can be set

Contribution Checklist

@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.05%. Comparing base (cff1df0) to head (d34abf7).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #615      +/-   ##
============================================
+ Coverage     98.94%   99.05%   +0.11%     
- Complexity     3628     3643      +15     
============================================
  Files           545      548       +3     
  Lines          8019     8048      +29     
  Branches        444      444              
============================================
+ Hits           7934     7972      +38     
+ Misses           64       56       -8     
+ Partials         21       20       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@superchilled superchilled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Just one suggestion re the ttl bounds.

However, looking at the tests you added I did notice another issue. The trustedRecipient param should be a top-level param, not part of the rcs object (see the spec).

Would probably make sense to fix that as part of this same PR.

@dragonmantank dragonmantank merged commit 228720e into main Mar 5, 2026
16 checks passed
@dragonmantank dragonmantank deleted the rcs-fixes branch March 5, 2026 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants