Skip to content

fix: refresh rush lockfile for Node 24 canvas install#2065

Merged
xile611 merged 7 commits into
developfrom
fix/node24-canvas-2-lockfile
Apr 1, 2026
Merged

fix: refresh rush lockfile for Node 24 canvas install#2065
xile611 merged 7 commits into
developfrom
fix/node24-canvas-2-lockfile

Conversation

@xile611
Copy link
Copy Markdown
Contributor

@xile611 xile611 commented Mar 31, 2026

Summary

  • refresh the Rush lockfile while keeping canvas 2.11.2
  • resolve canvas 2.11.2 installation on Node 24 by updating transitive resolutions in the lockfile
  • preserve the existing package manifests instead of upgrading canvas to 3.x

Verification

  • rush update --full
  • node -e require(canvas) createCanvas check in packages/vrender
  • pre-push hook ran rush test --only tag:package successfully

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds and wires up background-image layout capabilities (sizing + positioning) across stage/group/text rendering, and includes a browser demo page plus unit tests validating the new behavior.

Changes:

  • Introduce shared background-image layout helpers (drawBackgroundImage, sizing + position resolution) and use them in stage clear and background render contributions.
  • Extend core types/defaults to support backgroundSizing and backgroundPosition (CSS-like anchoring).
  • Add a browser demo page and a new Jest test suite covering layout behaviors and wrapped-background resource key handling.

Reviewed changes

Copilot reviewed 15 out of 16 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
packages/vrender/tests/browser/src/pages/index.ts Adds the new “background” demo page entry.
packages/vrender/tests/browser/src/pages/background.ts New browser demo exercising background sizing/position/clip across stage/group/text.
packages/vrender-core/src/render/contributions/render/draw-contribution.ts Uses shared background-image drawing during clear-screen for stage backgrounds.
packages/vrender-core/src/render/contributions/render/contributions/text-contribution-render.ts Adds clip/sizing/position forwarding for text background images.
packages/vrender-core/src/render/contributions/render/contributions/group-contribution-render.ts Forwards sizing/position and updates resource-key lookup for group background images.
packages/vrender-core/src/render/contributions/render/contributions/base-contribution-render.ts Adds shared sizing/position logic + resource-key normalization helpers.
packages/vrender-core/src/interface/stage.ts Broadens stage background typing to allow graphic background types.
packages/vrender-core/src/interface/render.ts Broadens clear typing to match graphic background types.
packages/vrender-core/src/interface/layer.ts Broadens layer background typing to match graphic background types.
packages/vrender-core/src/interface/graphic.ts Introduces backgroundSizing/backgroundPosition types + docs.
packages/vrender-core/src/graphic/graphic.ts Unwraps { background: ... } when loading background images.
packages/vrender-core/src/graphic/config.ts Adds defaults for backgroundSizing and backgroundPosition.
packages/vrender-core/src/core/stage.ts Updates stage background type and background-image loading behavior.
packages/vrender-core/src/core/layer.ts Aligns layer background type with updated interface.
packages/vrender-core/tests/background/background-image-layout.test.ts New tests covering sizing/positioning and resource-key normalization.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/vrender/__tests__/browser/src/pages/background.ts Outdated
Comment thread packages/vrender-core/src/core/stage.ts Outdated
Comment thread packages/vrender-core/src/core/stage.ts Outdated
chore: update Node.js versions in workflows and rush configuration
@xile611 xile611 force-pushed the fix/node24-canvas-2-lockfile branch from 230ae96 to 8706a3d Compare March 31, 2026 10:11
@xile611 xile611 merged commit 0599ccf into develop Apr 1, 2026
5 of 8 checks passed
@xile611 xile611 deleted the fix/node24-canvas-2-lockfile branch April 1, 2026 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants