Add java-test-runner module to support running tests with pure Java#4197
Open
Gedochao wants to merge 4 commits intoVirtusLab:mainfrom
Open
Add java-test-runner module to support running tests with pure Java#4197Gedochao wants to merge 4 commits intoVirtusLab:mainfrom
java-test-runner module to support running tests with pure Java#4197Gedochao wants to merge 4 commits intoVirtusLab:mainfrom
Conversation
Gedochao
force-pushed
the
feature/pure-java-test-runner
branch
2 times, most recently
from
dcebf1c to
ea12ffb
Compare
Gedochao
force-pushed
the
feature/pure-java-test-runner
branch
from
ea12ffb to
67cc76d
Compare
tgodzik
approved these changes
Mar 30, 2026
Member
tgodzik
left a comment
tgodzik
left a comment
There was a problem hiding this comment.
LGTM, just one questions otherwise
|
|
||
| public static List<String> commonTestFrameworks() { | ||
| return Arrays.asList( | ||
| "munit.Framework", |
Member
There was a problem hiding this comment.
Can we actually run these test from Java runner? Don't we only want junit?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3010
This essentially adds a new (pure Java)
java-test-runnermodule to Scala CLI, which is essentially a Java rewrite of the existingtest-runner.This in turn enables to not add Scala to test builds for Java projects.
I also added some extra logging to the old
test-runnerto get it on par with the newjava-test-runner.Checklist
scala-cli fmt .)scalafix(./mill -i __.fix)./mill -i 'generate-reference-doc[]'.run)How much have your relied on LLM-based tools in this contribution?
extensively, Cursor + Claude
How was the solution tested?
java-test-runnermodule included