Skip to content

chat(protocol="chat_completions") and the compat note on chat_completions() #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rejojer wants to merge 7 commits into
base: main
Choose a base branch
from
Open

chat(protocol="chat_completions") and the compat note on chat_completions() #493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9f3c44d
chat(protocol="chat_completions") and the compat note on chat_complet…
rejojer Sep 8, 2026
90f2631
Review fixes: type and document the chat_completions protocol value
rejojer Sep 8, 2026
9e7b9eb
Review fixes: name the lanes in error text, finish the chat() steer s…
rejojer Sep 9, 2026
4e9a98b
Fix managed chat stream overrides in extra_body
rejojer Sep 10, 2026
3aed646
Clarify chat completions protocol parameter documentation
rejojer Sep 10, 2026
32c4727
chat(): keyword-only after messages, type the protocol value
rejojer Sep 10, 2026
1ab028a
fix: prevent managed chat extras from overriding document scope
rejojer Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions cookbook/agentic_retrieval.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,11 +339,7 @@
"source": [
"query = \"What are the evaluation methods used in this paper?\"\n",
"\n",
"for chunk in pi_client.chat_completions(\n",
" messages=[{\"role\": \"user\", \"content\": query}],\n",
" doc_id=doc_id,\n",
" stream=True\n",
"):\n",
"for chunk in pi_client.chat(query, doc_id=doc_id, stream=True):\n",
" print(chunk, end='', flush=True)"
]
},
Expand Down Expand Up @@ -426,11 +422,8 @@
"\n",
"full_response = \"\"\n",
"\n",
"for chunk in pi_client.chat_completions(\n",
" messages=[{\"role\": \"user\", \"content\": retrieval_prompt}],\n",
" doc_id=doc_id,\n",
" stream=True\n",
"):\n",
"for chunk in pi_client.chat(retrieval_prompt, doc_id=doc_id, stream=True,\n",
" show_process=False):\n",
" print(chunk, end='', flush=True)\n",
" full_response += chunk"
]
Expand Down
Loading
Loading