Repository navigation
fix: honor stop() called while start() is still connecting - #182
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stop()did nothing when it ran before the Daily call object existed.start()kept going, joined the call, and emittedcall-startafter the caller had already ended the session.This change adds a start generation counter.
stop()increments it, andstart()checks it after each await thatstop()can overtake:join()resolves or rejects.A cancelled
start()returnsnullwithout joining, without emittingcall-start-failedorcall-start-success, and without touching a call object that a newerstart()created.Fixes #26
Testing
Added
__tests__/stopWhileConnecting.test.tswith five cases: stop during web call creation, no failure event for a cancelled start, stop then a new start with the first still pending, stop duringjoin(), and stop during the mobile permission wait.vapi.ts: 5 failed, 0 passed.