Open
Conversation
aurreco-uga
approved these changes
Feb 7, 2023
ryanrdoherty
requested changes
Feb 9, 2023
Member
ryanrdoherty
left a comment
ryanrdoherty
left a comment
There was a problem hiding this comment.
I think this will break the sequence reporter for these record classes. Doesn't the sequence reporter need to call these to get the regions to send to the service? The temporary result won't be able to look up the reporter if it is not in the model. If people don't want it to show up on the download page, you just need to remove the scopes (set scopes to an empty string).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Totally agreeing with Susanne that these options are not meaningful for the user. It was good for testing, but now we don't need it.