fix: use correct Python version in release workflow#67
Merged
micmarty-deepsense merged 6 commits intomainfrom Mar 3, 2026
Merged
fix: use correct Python version in release workflow#67micmarty-deepsense merged 6 commits intomainfrom
micmarty-deepsense merged 6 commits intomainfrom
Conversation
- Filter "none" from OTEL_TRACES_EXPORTER and OTEL_METRICS_EXPORTER - Return None from get_trace_provider/get_metric_provider when no exporters - Prevents NotImplementedError on plugin startup with OTEL disabled - Bump version 0.0.41 → 0.0.42 Fixes plugin crash when OTEL_TRACES_EXPORTER=none or OTEL_METRICS_EXPORTER=none
Covers get_settings() filtering, provider None returns, and the wrap_in_fastapi no-crash regression for OTEL_TRACES_EXPORTER=none and OTEL_METRICS_EXPORTER=none.
Replace `matrix.python-version` (undefined in this job) with `env.PYTHON_VERSION` so the release uses Python 3.10 as intended. Also drop the unnecessary `make install-dependencies` step — the release job only needs `uv build` and the publish action.
Chmielok
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The release workflow was using
${{ matrix.python-version }}but there's no matrix in this job.setup-uvfell back to the latest Python (3.14), which causedpydantic-coreto fail building from source — pyo3 0.24.1 only supports up to Python 3.13.The
PYTHON_VERSION: "3.10"env var was already defined but never referenced.Fix
python-version: ${{ matrix.python-version }}→${{ env.PYTHON_VERSION }}make install-dependencies— not needed in the release job (onlyuv build+ publish)Next step
After merging, delete and re-create the
0.0.42GitHub release to re-trigger this workflow.