Open
Conversation
The commit `4bb735f7966eedf414aa8e24533967cffd5bbcdb` only fixed the threading limit on the decoder part. Use the limit also in the encoder.
|
Hi @blaztinn we merged your fix in Dæmon engine's tree, this tree has also a lot of other fixes so you may be interested by it: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commit
4bb735f7966eedf414aa8e24533967cffd5bbcdbonly fixed thethreading limit on the decoder part. Use the limit also in the encoder.
Without this change we got random black squares on converted textures
when compressed on Macos with 24 threads.
The issue was not reproducible on Windows but I've added the limit there
also in case it is a race issue that is harder to trigger on Windows.