fix Linux/macOS HDF5_PLUGIN_PATH in miniconda.yml (compression plugin tests silently skip on ubuntu/macos) - #1495
Open
glaziermag wants to merge 1 commit into
Open
Conversation
…not hdf5/lib/plugin
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Linux and macOS, the Tests step in
miniconda.ymlexportsHDF5_PLUGIN_PATH="${CONDA_PREFIX}/hdf5/lib/plugin/"— a directory that doesn't exist in the micromamba env. conda-forge installs the netcdf-c filter plugins at${CONDA_PREFIX}/lib/hdf5/plugin(theH5_DEFAULT_PLUGINDIRbaked into conda-forge hdf5 — hdf5-feedstock build.sh L88 — which the libnetcdf feedstock uses as its plugin install dir). With the variable pointing at the empty path,has_zstd_filter()/has_bzip2_filter()/has_blosc_filter()return False andtest_compression_{zstd,bzip2,blosc}.pyskip with "filter not available" on every ubuntu/macos job of Build and Test, while the Windows jobs — whose${CONDA_PREFIX}\Library\hdf5\lib\pluginpath is correct — run them. Latest master run: ubuntu 3.12109 passed, 6 skippedvs windows 3.12111 passed, 3 skipped, 1 xpassed.Inside the workflow's env:
Verified on my fork at current master (ad9d7d8), runs 1 and 2: the unchanged path reproduces the three skips on ubuntu and macos (
109 passed, 6 skipped), and with this one-line change they run and pass, matching Windows (111 passed, 3 skipped, 1 xpassed). The Windows half of this export was tuned against CI directory listings in #1450 (8f83e40 "set HDF5_PLUGIN_PATH for tests"), but the Linux/macOS half kept the original guess from 2d6c8d4, and the skips keep the jobs green.Disclosure: found while auditing CI logs with an AI assistant (Claude); I re-read the workflow history and ran the fork verifications myself before opening this.