Fix/gperf token identifier boundary#1498
Merged
kareltucek merged 7 commits intomasterfrom Feb 23, 2026
Merged
Conversation
Test verifies that `if (1 == 2) tapKey i` produces no output when the condition evaluates to false. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
ConsumeGperfToken was using `> 32` to find token boundaries, treating any non-whitespace as part of the token. This caused `if(1 == 1)` to be parsed as token `if(1` instead of `if`. Now uses isIdentifierChar() to match the behavior of ConsumeToken(), correctly stopping at non-identifier chars like `(`. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add Macros_AnyMacroRunning() to check if macros are active - Add Macros_StopAllMacros() to forcibly stop all running macros - Stop all macros before each test starts - If macros still running after test completion, wait for timeout - Kill all macros when timeout occurs - Clean up macros at test suite finish Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported at https://forum.uhk.io/t/validation-changes-on-16-2-0/2840 and chained into a couple other issues.