Skip to content

Fix fallback issues with nodes destination in _barycentric_weights()#1450

Merged
erogluorhan merged 3 commits intomainfrom
bilinear_fix
Feb 3, 2026
Merged

Fix fallback issues with nodes destination in _barycentric_weights()#1450
erogluorhan merged 3 commits intomainfrom
bilinear_fix

Conversation

@erogluorhan
Copy link
Member

@erogluorhan erogluorhan commented Feb 2, 2026

Closes #1451

Overview

Fixes the fallback case in _barycentric_weights() that was pointed out in #1451.

Also adds a test case to test against a pair of mesh files for which UXarray's remap.bilinear(..., remap_to="nodes", ...) failed before.

PR Checklist

General

  • An issue is linked created and linked
  • Add appropriate labels
  • Filled out Overview and Expected Usage (if applicable) sections

Testing

  • Adequate tests are created if there is new functionality
  • Tests cover all possible logical paths in your function
  • Tests are not too basic (such as simply calling a function and nothing else)

Documentation

  • Docstrings have been added to all new functions

@erogluorhan erogluorhan changed the title Fix fallback case issues with nodes destination in _barycentric_weigh… Fix fallback issues with nodes destination in _barycentric_weights Feb 2, 2026
@erogluorhan erogluorhan changed the title Fix fallback issues with nodes destination in _barycentric_weights Fix fallback issues with nodes destination in _barycentric_weights() Feb 2, 2026
@erogluorhan erogluorhan added the bug Something isn't working label Feb 3, 2026
@erogluorhan erogluorhan marked this pull request as ready for review February 3, 2026 18:54
@erogluorhan erogluorhan merged commit 4b9985d into main Feb 3, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bilinear remapping in some remap_to="nodes" cases

1 participant