Conversation
philipc2
reviewed
Oct 28, 2024
Member
philipc2
left a comment
philipc2
left a comment
There was a problem hiding this comment.
These benchmarks look great! If you want to render the results of this branch, you can run the following on your machine:
asv publish
asv preview
This will create a website locally for you to view the results.
I will say the only thing that sticks out to me is that there appear to be some benchmarks that weren't run for the v2024.07.1 branch
May you look into this? It may be an issue with our script, but I am not sure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmarking results ran on Derecho completed with UXarray-asv. Benchmarked from tag v2024.07.0 to the most current tag as of Oct 25, 2024.