Fix bare except clauses in trade request exception handling#121
Draft
Copilot wants to merge 2 commits intorefactor_modelsfrom
Draft
Fix bare except clauses in trade request exception handling#121Copilot wants to merge 2 commits intorefactor_modelsfrom
Copilot wants to merge 2 commits intorefactor_modelsfrom
Conversation
Co-authored-by: Foosec <31885466+Foosec@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update based on feedback for model refactor
Fix bare except clauses in trade request exception handling
Dec 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses code review feedback on PR #116 regarding exception handling anti-patterns.
Two bare
except:clauses in the trade request queue view were catchingBaseException, which includes system exceptions likeKeyboardInterruptandSystemExitthat should propagate.Changes:
timetable/views.pylines 1123, 1158: Changedexcept:toexcept Exception:in fallback timetable_slug retrieval blocksBoth blocks are defensive fallbacks for extracting redirect context when not explicitly provided. The silent failure behavior is intentional - the code continues with a generic redirect if timetable_slug cannot be determined.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.