Skip to content

Clarify: nested bioghist is valid EAD — no code change needed#31

Closed
Copilot wants to merge 1 commit intoindex_creatorsfrom
copilot/sub-pr-8-again
Closed

Clarify: nested bioghist is valid EAD — no code change needed#31
Copilot wants to merge 1 commit intoindex_creatorsfrom
copilot/sub-pr-8-again

Conversation

Copy link
Contributor

Copilot AI commented Mar 4, 2026

An automated reviewer flagged nested <bioghist> elements as invalid EAD and suggested restructuring the injection logic to use siblings instead. This was incorrect.

Finding

Both EAD2002 and EAD3 explicitly permit <bioghist> as a child of <bioghist> — nesting is a standard pattern for grouping related biographical/historical notes. The current approach in get_creator_bioghist() + the injection block at main.py:284–293 produces valid EAD as-is.

No code changes are required. This PR documents the investigation and closes out the review thread.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copy link
Contributor Author

Copilot AI commented Mar 4, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • eadiva.com
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)
  • www.loc.gov
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Update nested bioghist in creator record generation Clarify: nested bioghist is valid EAD — no code change needed Mar 4, 2026
@alexdryden alexdryden closed this Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants