Enforce strict creator_{type}_{id} pattern using filename only

[Copilot]

• Understand the feedback: ALWAYS use creator_{entity_type}_{id} format
• Review code in main.py that creates files with this pattern (lines 552, 888)
• Identify duplicate fallback logic in traject config
• Simplify ID extraction logic to remove name-based ID generation
• Extract regex pattern to constant (CREATOR_ID_PATTERN)
• Use specific entity types (corporate_entities, people, families)
• Remove recordId extraction - use filename ONLY as source of truth
• Clean up verbose comments to 1-2 lines max
• Run security checks (no issues found)

Summary

Successfully refactored the EAC-CPF traject configuration to use ONLY the filename pattern for ID extraction with concise, clear comments.

Latest Change (commit):

• Cleaned up all verbose comments to be concise (1-2 lines max)
• Removed redundant inline comments
• Kept essential information: pattern is from arcflow's file naming

Pattern: creator_(corporate_entities|people|families)_{numeric_id} extracted from filename only

All Commits:

1. Remove duplicate ID fallback logic and enforce creator_{type}_{id} pattern (53 lines removed)
2. Extract regex to constant and use specific entity types
3. Use filename only for ID extraction, remove recordId fallback (17 lines removed)
4. Clean up comments to be concise (removed verbose multi-line comments)

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[alexdryden]

@copilot this is wrong. If successful, this would get the id from the recordId. Because that can't be relied on and we need to know how ids are constructed ONLY use the pattern

[Copilot]

Fixed in commit b113430. Removed all recordId extraction logic - now exclusively using the filename as the single source of truth for IDs. The code now only extracts the ID from the filename pattern and validates it against CREATOR_ID_PATTERN.

[alexdryden]

@copilot clean up the comments. we need at most one line that says this is the pattern from arcflow when creating the files. keep it to 1-2 lines and only one comment max.

[Copilot]

Cleaned up in commit 874dc9c. Reduced all comments to 1-2 lines max, keeping only essential information about the arcflow pattern.