Clarify modified_since parameter behavior in get_all_agents

[Copilot]

Responded to review question about whether the current ternary expression is equivalent to the suggested if/elif logic for handling the modified_since parameter in get_all_agents().

Current Behavior

The existing code unconditionally overwrites the modified_since parameter:

modified_since = 0 if self.force_update else int(self.last_updated.timestamp())

Suggested Change

The bot reviewer suggested respecting the passed parameter value:

if self.force_update:
    modified_since = 0
elif not modified_since:
    modified_since = int(self.last_updated.timestamp())

Clarification Provided

These are not functionally equivalent. The current ternary ignores any passed value; the suggested logic honors it when non-zero.

Offered alternative ternary form if preferred:

modified_since = 0 if self.force_update else (modified_since or int(self.last_updated.timestamp()))

Awaiting decision on which approach to implement.

---

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.