feat(ui5-toolbar): implement WCAG-compliant keyboard navigation#13231
Open
plamenivanov91 wants to merge 4 commits intomainfrom
Open
feat(ui5-toolbar): implement WCAG-compliant keyboard navigation#13231plamenivanov91 wants to merge 4 commits intomainfrom
plamenivanov91 wants to merge 4 commits intomainfrom
Conversation
Add comprehensive keyboard navigation to toolbar following WCAG toolbar pattern: - Arrow keys (Left/Right/Up/Down) navigate between toolbar items - Home/End jump to first/last item - Tab/Shift+Tab navigate within toolbar, exit at edges - Roving tabindex pattern (single tab stop, toolbar is one stop) - Focus entry: remembers last focused item on re-entry, defaults to first item on initial entry - Proper handling of complex nested controls (ToolbarSelect) Resolves focus loss when pressing Shift+Tab on complex toolbar children. Ensures all toolbar items are reachable via keyboard navigation. Optimizations: - Extracted _focusItem() helper to reduce code duplication - Simplified Tab/Shift+Tab navigation logic Fixes: #12945
Collaborator
|
🚀 Deployed on https://pr-13231--ui5-webcomponents-preview.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add comprehensive keyboard navigation to toolbar following WCAG toolbar pattern:
Resolves focus loss when pressing Shift+Tab on complex toolbar children. Ensures all toolbar items are reachable via keyboard navigation.
Optimizations:
Fixes: #12945