chore(ui5-carousel): standardize internal naming (slide→page, remove Active/Selected/Viewport)#13204
Merged
TeodorTaushanov merged 4 commits intomainfrom Mar 10, 2026
Merged
chore(ui5-carousel): standardize internal naming (slide→page, remove Active/Selected/Viewport)#13204TeodorTaushanov merged 4 commits intomainfrom
TeodorTaushanov merged 4 commits intomainfrom
Conversation
Collaborator
|
🧹 Preview deployment cleaned up: https://pr-13204--ui5-webcomponents.netlify.app |
dimovpetar
approved these changes
Mar 10, 2026
Stoev
reviewed
Mar 10, 2026
Stoev
left a comment
Stoev
left a comment
There was a problem hiding this comment.
Please consider as alternative:
chore(ui5-carousel): standardize internal naming (slide→page, remove Active/Selected/Viewport)
TeodorTaushanov
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace “slide” → “page” and correct any places where “page” should actually be “item”.
Remove Active, Selected and Viewport words.