fix(ui5-step-input): value with group separator is parsed correctly#13093
Merged
fix(ui5-step-input): value with group separator is parsed correctly#13093
Conversation
Collaborator
|
🧹 Preview deployment cleaned up: https://pr-13093--ui5-webcomponents.netlify.app |
NHristov-sap
approved these changes
Mar 5, 2026
NHristov-sap
approved these changes
Mar 6, 2026
tsanislavgatev
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where ui5-step-input incorrectly parsed values when users typed group separators (thousand separators) manually. The component now correctly handles and removes group separators based on the current locale before parsing the numeric value.
Problem
When users typed values with group separators (e.g., "1,000" or "10,000"), the component's parsing logic didn't strip these separators before converting the string to a number. This caused incorrect value parsing and display issues.
For example, typing "1,0000" would not be properly formatted to "10,000" and the underlying value property would not be set correctly.