Pass useDefineForClassFields tsconfig compiler option to SWC#2049
Closed
valentin-nemcev wants to merge 1 commit intoTypeStrong:mainfrom
Closed
Pass useDefineForClassFields tsconfig compiler option to SWC#2049valentin-nemcev wants to merge 1 commit intoTypeStrong:mainfrom
valentin-nemcev wants to merge 1 commit intoTypeStrong:mainfrom
Conversation
Defaults for this option may be different between tsc and SWC, and explicit override in ts-node is ignored. This prevents drop-in replacement of `ts-node --swc` in place of `ts-node` for cases when the value of `useDefineForClassFields` is important
Merged
Collaborator
|
Fixed via #2062 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defaults for this option may be different between tsc and SWC, and explicit override in ts-node is ignored.
This prevents drop-in replacement of
ts-node --swcin place ofts-nodefor cases when the value ofuseDefineForClassFieldsis importantHere is an example of the problem this PR is attempting to fix:
tsconfig.json:
{ "compilerOptions": { "target": "es2021", "useDefineForClassFields": false } }