CompatHelper: bump compat for SciMLBase to 3, (keep existing compat)#2802
Conversation
82458a3 to
d2a7721
Compare
|
Turing.jl documentation for PR #2802 is available at: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2802 +/- ##
=======================================
Coverage 85.23% 85.23%
=======================================
Files 22 22
Lines 1483 1483
=======================================
Hits 1264 1264
Misses 219 219 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Note that the successful CI run was with SciMLBase@2 |
|
This PR cannot be merged: Optimization is not yet compatible with SciMLBase@3 Edit: see SciML/Optimization.jl#1179 for upstream progress |
|
Courtesy note from the SciMLBase v3 ecosystem sweep: this PR is low-risk from the v3 breaking-surface perspective. A grep of One ecosystem-wide caveat: For reference, the SciML-side pattern PR with full breaking-change context is SciML/DiffEqCallbacks.jl#300. |
d2a7721 to
4a2d653
Compare
|
Actually there's no reason why we need to directly version SciMLBase in Turing, we only use it to import OptimizationSolution, which we can just import from Optimization. That may lead to a transitive compat bound, but that's not something we need to worry about in our Project.toml. |
|
Actually plot twist but OptimizationSolution isn't even public / exported |
|
That is a mistake on our end, we'll correct that. |
This reverts commit 4a2d653.
This pull request changes the compat entry for the
SciMLBasepackage from2to2, 3.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.