Update CONTRIBUTING.md to provide better guidelines about translation#2245
Update CONTRIBUTING.md to provide better guidelines about translation#2245
Conversation
|
Okay |
|
@Brackets-Coder Sorry for requesting another review, I didn't know what that button did. |
Brackets-Coder
left a comment
There was a problem hiding this comment.
I'm approving this but I'm still going to wait...
|
If you're coming here because I requested a review from the whole team, I apologize. I figured that this would be relevant to all of us. Please add a thumbs-down emoji in the little emoji reaction button if that annoyed you. |
|
It's relevant to all of us, but I don't think you should request a review from the whole team... personally, I think something like this is better for Mr. Weber to review. |
Should I revoke the request for review? |
|
You should include not using translation.setup or whatever it's called. Also include how to use that function |
I don't know nearly enough about this stuff because it's poorly documented (that's why this PR is still a draft). Feel free to request changes if you have a more in-depth explanation! |
For the "how to use part", just say smt like: Then say do not use Scratch.translate.setup or whatever it is |
I really think that there should be a seperate page in the documentation about this, which I can then link to. |
|
Not rlly sure how important that is given that it's 2 lines |
|
This is getting bad. #2269 is completely lacking Edit: I'm currently rewriting the documentation to use the |
|
@GarboMuffin Would you please merge TurboWarp/docs#122 so that there's documentation to go along with this PR? |
Dismissing old approvals so that moving forward everything follows #2327
|
#2327 does this as a side effect |
I've noticed that a lot of developers writing new extensions for TurboWarp are not paying much attention to the translatability of their work, and I don't blame them. Nowhere in the documentation or contribution guidelines do we mention things like
Scratch.translate(), and so many extensions take much longer to refine before they get accepted.I have written a rough draft for improved guidelines that will hopefully make this situation much more manageable. A lot of help is needed; feel free to improve it!