qubes-dom0-packagev2.yml: update for latest builderv2#15
Open
qubes-dom0-packagev2.yml: update for latest builderv2#15
Conversation
The updated building workflow is meant to be ran on a GitHub worker with Ubuntu 24.04. For this case the workflow disables AppArmor and, given the required recent Sequoia release, installs Rust with the recommended method available at https://rust-lang.org/tools/install/. Signed-off-by: Kamil Aronowski <kamil.aronowski@3mdeb.com>
aronowski
force-pushed
the
build-for-remote-signing
branch
from
bdbba48 to
b102a70
Compare
aronowski
changed the title
DaniilKl
suggested changes
Feb 5, 2026
| with: | ||
| repository: QubesOS/qubes-builderv2 | ||
| ref: 80dd898cc0472dd99f161f1d1c7c44da64de93f2 | ||
| ref: 5327e41b3d68befc61bee87fb1ac0033662d575f |
There was a problem hiding this comment.
Please add a reason for this change to commit message.
Comment on lines
215
to
241
| - name: Save built packages | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| if-no-files-found: error | ||
| name: qubesos.dom0.fc37-${{ inputs.qubes-component }}-${{ github.sha }} | ||
| path: '*.rpm' | ||
|
|
||
| - name: Construct release's description | ||
| if: github.event_name == 'push' && github.ref_type == 'tag' | ||
| run: | | ||
| for artifact in *.rpm; do | ||
| echo "### $artifact" >> release-body.md | ||
| echo '```' >> release-body.md | ||
| echo "wget --quiet '${{ github.server_url }}/${{ github.repository }}/releases/download/${{ github.ref_name }}/$artifact'" >> release-body.md | ||
| echo '```' >> release-body.md | ||
| echo '```' >> release-body.md | ||
| echo "curl --remote-name '${{ github.server_url }}/${{ github.repository }}/releases/download/${{ github.ref_name }}/$artifact'" >> release-body.md | ||
| echo '```' >> release-body.md | ||
| done | ||
|
|
||
| - name: Create release for a new tag | ||
| if: github.event_name == 'push' && github.ref_type == 'tag' | ||
| uses: ncipollo/release-action@v1.14.0 | ||
| with: | ||
| artifacts: '*.rpm' | ||
| artifactErrorsFailBuild: true | ||
| bodyFile: "release-body.md" |
There was a problem hiding this comment.
We should not publish untested and unsigned packages on GitHub release page. Please, make sure this workflow publishes packages only on https://dl.3mdeb.com/tmp/rpm/QubesOS under current-testing for needed QubesOS release number.
There was a problem hiding this comment.
As discussed internally, my comment here is not correct, as in this project project it is acceptable to do such pushes.
There was a problem hiding this comment.
I cannot resolve my thread unfortunately, but assume it is resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The updated building workflow is meant to be ran on a GitHub worker with Ubuntu 24.04. For this case the workflow disables AppArmor and, given the required recent Sequoia release, installs Rust with the recommended method available at https://rust-lang.org/tools/install/.