Skip to content

Fix container-image properties for LRE rust#2271

Merged
palfrey merged 1 commit intoTraceMachina:mainfrom
palfrey:container-image-lre-rs
Apr 9, 2026
Merged

Fix container-image properties for LRE rust#2271
palfrey merged 1 commit intoTraceMachina:mainfrom
palfrey:container-image-lre-rs

Conversation

@palfrey
Copy link
Copy Markdown
Member

@palfrey palfrey commented Apr 9, 2026

Description

Makes remote execution builds of Nativelink work again

Type of change

Please delete options that aren't relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

bazle build //:nativelink with RBE config

Checklist

  • Updated documentation if needed
  • Tests added/amended
  • bazel test //... passes locally
  • PR is contained in a single commit, using git amend see some docs

This change is Reviewable

Copy link
Copy Markdown
Collaborator

@MarcusSorealheis MarcusSorealheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

# Some toolchains, like the darwin ones, don't have an actual container image.
# We still map them to the output of the tag of the corresponding theoretical
# worker image so that bare metal metal workers can advertise exact
# worker image so that bare metal workers can advertise exact
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@palfrey palfrey force-pushed the container-image-lre-rs branch from c721ea1 to 97e28eb Compare April 9, 2026 14:14
@palfrey palfrey merged commit 5e94e9b into TraceMachina:main Apr 9, 2026
35 of 36 checks passed
@palfrey palfrey deleted the container-image-lre-rs branch April 9, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants