Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Centralizes conditional lighting updates, adds invalidation tracking, improves grouped undo behavior, and expands lighting tests.
Changes:
- Adds deferred/immediate lighting update gateways and cache invalidation.
- Updates color, transform, move, delete, undo, and quality workflows.
- Adds comprehensive lighting regression tests.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
RoomGeometry.cs |
Applies global light-quality overrides. |
Room.cs |
Encapsulates and updates lighting invalidation. |
RoomLightingInvalidationTests.cs |
Tests room invalidation and quality overrides. |
Undo.cs |
Batches grouped-object lighting updates. |
Lighting.cs |
Avoids relighting for dynamic-only settings. |
FormTransform.cs |
Handles transform-time lighting updates. |
FormRoomProperties.cs |
Routes ambient updates through the gateway. |
FormReplaceObject.cs |
Routes replaced-light updates through the gateway. |
EditorActions.cs |
Centralizes object-related lighting updates. |
Editor.cs |
Adds conditional lighting update APIs. |
PanelPalette.cs |
Uses centralized color application. |
Command.cs |
Routes ambient color updates through the gateway. |
EditorLightingGatewayTests.cs |
Tests gateway, undo, movement, quality, and reset behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| obj.Color = c.ToFloat3Color() * 2.0f; | ||
| _editor.ObjectChange(obj as ObjectInstance, ObjectChangeType.Change); | ||
| }, _editor.Configuration.UI_ColorScheme)) | ||
| c => ApplyObjectColor(obj, c.ToFloat3Color() * 2.0f), |
Comment on lines
+129
to
+132
| if (!_undoSaved) | ||
| { | ||
| _editor.UndoManager.PushObjectTransformed(_instance); | ||
| _undoSaved = true; |
Collaborator
Author
|
Both comments Copilot found are pre-existing issues, but worth fixing in the future, the blast radius for those is too large to fix right now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need to test: