test(chat): separate packaged desktop evidence

[DeliciousBuding]

Summary

• Add an explicit skipped packaged-release row to the chat acceptance manifest.
• Keep executed evidence levels limited to gates that actually ran; packaged Desktop proof remains a separate opt-in gate.
• Update architecture/roadmap wording for the packaged Desktop boundary without adding new rules to AGENTS.

Evidence

• node tests/contract/scripts/verify-chat-acceptance.mjs --repo-root .
• node --check scripts/verify/chat-acceptance.mjs
• node scripts/verify/chat-acceptance.mjs --repo-root . --skip-shared-unit --skip-desktop-playwright --skip-web-playwright --skip-desktop-visual-qa --skip-web-visual-qa
• pwsh ./scripts/verify/verify-doc-ssot.ps1
• pwsh ./scripts/verify/verify-project-skills.ps1
• pwsh ./scripts/verify/verify-real-e2e-contract.ps1
• pwsh ./tests/contract/scripts/verify-tauri-package-readiness.ps1
• git diff --check

Boundary

packaged-release is listed as planned/skipped evidence in chat acceptance only. This PR does not run Tauri package, installer, signing, updater, release upload, real login, or real CLI/model/API execution.

Closes #391

Summary by CodeRabbit

• Documentation

  • Clarified acceptance requirements for desktop packaged builds, including what counts as valid proof and when a skipped boundary is acceptable.
  • Updated progress and roadmap notes to reflect the new packaged-release handling in chat acceptance.

• Bug Fixes

  • Chat acceptance now records a skipped desktop packaged-release entry with clear status and evidence tracking.
  • Validation now confirms the skipped entry appears correctly and is excluded from executed checks while remaining planned.

[coderabbitai]

📝 Walkthrough

Walkthrough

Adds a permanently-skipped packaged-desktop-release gate (surface: desktop, evidence level: packaged-release) to scripts/verify/chat-acceptance.mjs. Contract tests are extended to assert the row's skipped status, real_tested=false, and planned_evidence_levels membership. Architecture, roadmap, and progress docs are updated to reflect the opt-in boundary separation.

Packaged Desktop gate separation

Layer / File(s)	Summary
Add skipped packaged-desktop-release gate scripts/verify/chat-acceptance.mjs	Adds a runGate call for packaged-desktop-release with skip: true and a fixed skip reason, recording an extra skipped row in the acceptance manifest.
Contract test assertions for skipped gate tests/contract/scripts/verify-chat-acceptance.mjs	Extends schema row checks to include packaged-desktop-release, adds packaged-release to the evidence-level loop, and asserts the row is skipped, has real_tested=false, is absent from executed evidence_levels, and present in planned_evidence_levels.
Docs alignment docs/architecture.md, docs/roadmap.md, docs/progress/MASTER.md	Updates the Acceptance Gates table, Desktop packaged boundary row, and session log to reflect the opt-in packaged-release gate separation from chat acceptance.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related issues

• [T4.3] Keep packaged Desktop claim separate #391: This PR directly implements T4.3 — separates Vite renderer evidence from packaged Desktop proof by adding an opt-in skipped gate and updating the affected files listed in the issue.
• [T4.1] Add focused chat acceptance gate #389: Both issues touch the chat acceptance workflow in scripts/verify/chat-acceptance.mjs and its contract tests.

Possibly related PRs

• TokenDanceLab/AgentHub#395: Directly related — established the chat-flow evidence manifest contract that this PR extends with the packaged-desktop-release/packaged-release row.
• TokenDanceLab/AgentHub#412: Modifies the same chat-acceptance.mjs and its contract test, adding gate coverage that this PR builds upon.

Poem

🐰 A gate stands skipped, opt-in and proud,
No Vite renderer sneaks through the cloud.
"packaged-release" waits on its own,
Real proof must come from Tauri alone.
Hop hop, the manifest is tidy and true! 🎉

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: separating packaged Desktop evidence in chat tests.
Linked Issues check	✅ Passed	The PR separates Vite renderer evidence from packaged-release proof, keeps the packaged Desktop gate opt-in, and avoids release/signing/updater claims.
Out of Scope Changes check	✅ Passed	The changes stay within the documented verifier, test, and docs updates needed for the packaged Desktop evidence split.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch task/391-packaged-claim-boundary

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/roadmap.md`:
- Line 58: The acceptance sentence in the “Desktop packaged boundary” row is
inconsistent with the PR’s `real_tested=false` contract. Update the wording in
the roadmap entry so `real_tested=false` is clearly presented as a
non-proof/skipped boundary, and reserve real packaged evidence for an explicit
`packaged-release` gate; keep the language aligned with the existing acceptance
contract used elsewhere in the docs.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 4d3dd2ff-1cc1-48c7-9791-cf4b568bd60e

📥 Commits

Reviewing files that changed from the base of the PR and between 7b4d4c6 and 7b8c44b.

📒 Files selected for processing (5)

• docs/architecture.md
• docs/progress/MASTER.md
• docs/roadmap.md
• scripts/verify/chat-acceptance.mjs
• tests/contract/scripts/verify-chat-acceptance.mjs

[coderabbitai]

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Clarify the acceptance sentence so real_tested=false is not described as real proof.

This row now says real packaged proof can come from a separate gate or real_tested=false, but the rest of this PR defines real_tested=false as the explicit non-proof boundary. That contradiction makes the acceptance contract easier to misread later.

Suggested wording

-| Desktop packaged boundary | 区分 Vite renderer、Tauri packaged、sidecar、icon、installer/signing | chat acceptance 只列 skipped `packaged-release` 边界；真实证明走独立 packaged-release gate 或明确 `real_tested=false` |
+| Desktop packaged boundary | 区分 Vite renderer、Tauri packaged、sidecar、icon、installer/signing | chat acceptance 只列 skipped `packaged-release` 边界并保持 `real_tested=false`；真实证明仅走独立 packaged-release gate |

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	| Desktop packaged boundary | 区分 Vite renderer、Tauri packaged、sidecar、icon、installer/signing | chat acceptance 只列 skipped `packaged-release` 边界；真实证明走独立 packaged-release gate 或明确 `real_tested=false` |
	| Desktop packaged boundary | 区分 Vite renderer、Tauri packaged、sidecar、icon、installer/signing | chat acceptance 只列 skipped `packaged-release` 边界并保持 `real_tested=false`；真实证明仅走独立 packaged-release gate |

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@docs/roadmap.md` at line 58, The acceptance sentence in the “Desktop packaged
boundary” row is inconsistent with the PR’s `real_tested=false` contract. Update
the wording in the roadmap entry so `real_tested=false` is clearly presented as
a non-proof/skipped boundary, and reserve real packaged evidence for an explicit
`packaged-release` gate; keep the language aligned with the existing acceptance
contract used elsewhere in the docs.