fix(logic): Add nullptr check to thisPlayer in GameLogic::logicMessageDispatcher#2383
Draft
Caball009 wants to merge 3 commits intoTheSuperHackers:mainfrom
Draft
fix(logic): Add nullptr check to thisPlayer in GameLogic::logicMessageDispatcher#2383Caball009 wants to merge 3 commits intoTheSuperHackers:mainfrom
Caball009 wants to merge 3 commits intoTheSuperHackers:mainfrom
Conversation
|
on 645 we have I wonder if this needs clarifying that I am guessing that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the
nullptrassertion onthisPlayerinGameLogic::logicMessageDispatcherto an early return. Although there are a couple of places in this function that check explicitly for it, a lot of code assumes that this pointer is not null, so it makes sense to check that up front.Commit 1 adds the check.
Commit 2 removes code that's become redundant (implicitly).
Commit 3 changes
msg->getPlayerIndextothisPlayer->getPlayerIndexfor the sole purpose of consistency with code that already uses the latter.TODO: