Remove two redundant lines of code setting io.DisplaySize in ImGuiLayer.cpp#660
Open
littlecaca wants to merge 1 commit intoTheCherno:masterfrom
Open
Remove two redundant lines of code setting io.DisplaySize in ImGuiLayer.cpp#660littlecaca wants to merge 1 commit intoTheCherno:masterfrom
littlecaca wants to merge 1 commit intoTheCherno:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hazel/Hazel/src/Hazel/ImGui/ImGuiLayer.cpp
Lines 100 to 101 in 1feb705
This is redundant because the "ImGui_ImplGlfw_NewFrame();" has done this work. That is in
Hazel/Hazel/src/Hazel/ImGui/ImGuiLayer.cpp
Lines 89 to 91 in 1feb705
And the definition of ImGui_ImplGlfw_NewFrame() is in:https://github.com/TheCherno/imgui/blob/3cf61f67de73153e29e0c26f23d80edbaf120a3d/examples/imgui_impl_glfw.cpp#L473-L477
So, I removed them. Not confirmed its working state.