est: create via resistors in series between tree and pin nodes#9297
Conversation
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
…e same layer Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
…ROAD into est_via_res Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses a crucial aspect of parasitic extraction by correctly modeling via connections in series, rather than in parallel, and improving the handling of pins above the tree layer. The introduction of insertViaResistances and getMaxIndex facilitates the creation of intermediate parasitic nodes, leading to a more accurate representation of the physical layout. The update to getPinLayer to filter by routing layer type is a good correctness enhancement. The changes in the test output files (.ok files) are expected due to these functional improvements. Overall, the changes are well-implemented and align with the stated objectives of the pull request.
…ROAD into est_via_res Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
…ROAD into est_via_res Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
openroad-ci
force-pushed
the
est_via_res
branch
from
28a6ee8 to
1b675d4
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
|
@maliberty The changes in this PR were already reviewed here: #8426; At that time, I closed it because of some bad CI results, but now it should be good to go. I'm running a secure-ci, and the metric updates will be added here: The-OpenROAD-Project/OpenROAD-flow-scripts#3819 |
3 participants
Fixes #8408.
Vias were being added directly to the tree node, making the connection in parallel instead of in series, as it would be expected for via connections. This PR changes how they are created by adding extra nodes in the middle of the connection.
Also, this PR has a fix for pins above the tree layer. They would not be properly connected due to the assumption that all pins were below the tree layer.