Skip to content

fix(migration): quote camelCase identifiers in compression option strings #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TerrifiedBug merged 1 commit into from
Apr 26, 2026
Merged

fix(migration): quote camelCase identifiers in compression option strings #181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 21 additions & 13 deletions prisma/migrations/20260329000001_timescaledb_compression/migration.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,19 @@
-- Achieves 10-20x size reduction for time-series metric data.
-- Safe no-op on plain PostgreSQL.
--
-- Note on compress_orderby: every column of the hypertable's primary key
-- (changed to ("id", "timestamp") in the previous migration) must appear in
-- either compress_segmentby or compress_orderby. We put "id" in orderby —
-- segmenting by a high-cardinality cuid would create one segment per row and
-- destroy the compression ratio.
-- Two case-sensitivity gotchas in the option-string format:
--
-- 1. TimescaleDB's parser for compress_segmentby / compress_orderby folds
-- unquoted identifiers to lowercase, just like PostgreSQL's regclass
-- parser. Columns like "pipelineId" / "nodeId" / "timestamp" / "id" must
-- be wrapped in double quotes inside the string literal — otherwise we
-- get "column pipelineid does not exist".
--
-- 2. Every column of the hypertable's primary key (changed to ("id",
-- "timestamp") in the previous migration) must appear in either
-- compress_segmentby or compress_orderby. We put "id" in orderby —
-- segmenting by a high-cardinality cuid would create one segment per
-- row and destroy the compression ratio.

DO $$
BEGIN
Expand All @@ -17,8 +25,8 @@ BEGIN
-- ─── PipelineMetric compression ─────────────────────────────────────
ALTER TABLE "PipelineMetric" SET (
timescaledb.compress,
timescaledb.compress_segmentby = 'pipelineId',
timescaledb.compress_orderby = 'timestamp DESC, id'
timescaledb.compress_segmentby = '"pipelineId"',
timescaledb.compress_orderby = '"timestamp" DESC, "id"'
);

SELECT add_compression_policy(
Expand All @@ -30,8 +38,8 @@ BEGIN
-- ─── NodeMetric compression ─────────────────────────────────────────
ALTER TABLE "NodeMetric" SET (
timescaledb.compress,
timescaledb.compress_segmentby = 'nodeId',
timescaledb.compress_orderby = 'timestamp DESC, id'
timescaledb.compress_segmentby = '"nodeId"',
timescaledb.compress_orderby = '"timestamp" DESC, "id"'
);

SELECT add_compression_policy(
Expand All @@ -43,8 +51,8 @@ BEGIN
-- ─── PipelineLog compression ────────────────────────────────────────
ALTER TABLE "PipelineLog" SET (
timescaledb.compress,
timescaledb.compress_segmentby = 'pipelineId',
timescaledb.compress_orderby = 'timestamp DESC, id'
timescaledb.compress_segmentby = '"pipelineId"',
timescaledb.compress_orderby = '"timestamp" DESC, "id"'
);

SELECT add_compression_policy(
Expand All @@ -56,8 +64,8 @@ BEGIN
-- ─── NodeStatusEvent compression ────────────────────────────────────
ALTER TABLE "NodeStatusEvent" SET (
timescaledb.compress,
timescaledb.compress_segmentby = 'nodeId',
timescaledb.compress_orderby = 'timestamp DESC, id'
timescaledb.compress_segmentby = '"nodeId"',
timescaledb.compress_orderby = '"timestamp" DESC, "id"'
);

SELECT add_compression_policy(
Expand Down
Loading