feat(chat): Ask / Plan / Craft conversation modes (#616) - #623
Open
huangcheng wants to merge 5 commits into
Open
feat(chat): Ask / Plan / Craft conversation modes (#616)#623huangcheng wants to merge 5 commits into
huangcheng wants to merge 5 commits into
Conversation
4 tasks
Turn-scoped conversation_mode stamps tools and system hints through ConversationModeMiddleware (no harness kernel changes). Dashboard adds mode picker, PlanReady silent Craft handoff with plan_brief, and agent default mode on create/edit.
Keep composer resources when executing a plan, persist mode per thread, and pass planBrief on new sessions so Plan→Craft handoff does not drop context.
Fall back to agent default mode and /mode thread sticky when meta omits mode; Ask blocks write_todos; PlanReady needs todos or a long brief; add agent default_knowledge_base_ids and document builtin-only denylist.
Preserve the composer conversation mode when an empty/pending chat gets its first thread id, and ignore stale __pending__ overrides so Ask/Craft turns are not forced back into Plan.
Scope plan brief collection to the latest user→assistant turn so a short ack after an earlier todos turn cannot reopen PlanReady with old steps.
huangcheng
force-pushed
the
feature/conversation-modes
branch
from
September 9, 2026 13:31
334854b to
8c57aa8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wrap_tool_call(Ask/Plan also blocktask/acp_runner/ask_agent).default_conversation_mode, PlanReady card, and silent Plan→Craft handoff viaplan_brief(no pink user bubble).planBriefon new sessions, contiguous plan todos, shared mode Select options.Closes #616
Test plan
uv run pytest tests/unit/agents/test_conversation_mode.py tests/unit/agents/test_conversation_mode_middleware.py tests/unit/agents/test_plan_artifact.py tests/unit/api/test_chat_conversation_mode.py tests/unit/api/test_agent_conversation_mode.py tests/unit/gateway/test_processor_conversation_mode.py tests/unit/i18n/test_conversation.py -qcd dashboard && npx tsc --noEmit(pre-commit also runsnpm run build)#616entries present