fix: remove project-scope hooks from user settings#44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
teamai hooks removeso it mirrors project-scope hook injection. When project scope injects hooks into both the project directory and the user HOME directory, remove now cleans both locations as well.This prevents TeamAI hooks from lingering in user-level tool settings after users run
teamai hooks removefrom a project-scope setup.Type of Change
Test Plan
.\node_modules\.bin\tsc.cmd --noEmitpasses.\node_modules\.bin\vitest.cmd run src/__tests__/hooks-cmd.test.tspassesnpm.cmd run buildpassesNotes for Reviewers
Project-scope hook injection already targeted both
projectRootandHOME. This change centralizes the target base-dir resolution and uses it for both inject and remove, so removal no longer leaves user-level TeamAI hooks behind.