Skip to content

Enforce firstname-lastname.md naming for people files #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TechNickAI merged 2 commits into from
Mar 26, 2026
Merged

Enforce firstname-lastname.md naming for people files #46

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b22033
Enforce firstname-lastname.md naming for people files (no firstname-o…
Mar 26, 2026
dfc1bf1
Add unknown-last-name fallback to people file naming rule
Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions skills/librarian/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,8 +214,9 @@ As part of each maintenance loop:

## File Conventions

- All filenames: **kebab-case** (`alex-chen.md`, not `Thomas Owen.md`)
- People files: `firstname-lastname.md` (or `firstname.md` if unambiguous)
- All filenames: **kebab-case** (`alex-chen.md`, not `Alex Chen.md`)
- People files: `firstname-lastname.md`; if last name unknown, use
`firstname-unknown.md` as a placeholder (never bare `firstname.md`)
Copy link
Copy Markdown

@cursor cursor bot Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming collision risk for multiple same-first-name unknowns

Low Severity

The firstname-unknown.md fallback creates a collision risk when two or more people share the same first name and both have unknown last names — e.g., two "Johns" would both map to john-unknown.md. The old firstname.md "if unambiguous" rule had an implicit guard against this. The new convention doesn't document how to disambiguate multiple unknowns with the same first name.

Fix in Cursor Fix in Web

Copy link
Copy Markdown
Owner Author

@TechNickAI TechNickAI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valid catch. Fixed in PR #48 — added descriptor pattern for disambiguation: , .

- Date files: `YYYY-MM-DD.md`
- Decision files: `YYYY-MM-DD-topic.md`
- All files are markdown
Expand Down
Loading