Merge upstream libwdi and align Windows ARM/ARM64 support paths - #1
Draft
DanTheMan827 with Copilot wants to merge 73 commits into
Draft
Merge upstream libwdi and align Windows ARM/ARM64 support paths#1DanTheMan827 with Copilot wants to merge 73 commits into
DanTheMan827 with Copilot wants to merge 73 commits into
Conversation
* Also improve display of wdi-simple options * Closes pbatard#140
* Cannot rely on the server to provide text/plain MIME for .ver files so remove the check * Also improve error reporting in installer due to unsigned CAT files
* Also update VS2019 PlatformToolSet to latest and fix amend script.
* Also update AppVeyor build image to VS2019 * Also remove wdk_build.cmd
* Also remove unused project file
* Closes pbatard#186
* Also ensure that system errors are reported in English
* Closes pbatard#190
There is a small typo in libwdi/libwdi_dlg.c. Should read `otherwise` rather than `othwerwise`.
docs: fix simple typo, othwerwise -> otherwise
* This *MIGHT* help with pbatard#168, pbatard#208 and similar issues. However, the root of the corruption appears to be with Windows' internal PKI behaviour. * Also alter the user cancellation error message, since, despite Microsoft's documentation at: https://docs.microsoft.com/en-us/windows/win32/api/shellapi/nf-shellapi-shellexecuteexw ShellExecuteExW() can return ERROR_CANCELLED without any user interaction.
* Closes pbatard#207
* These redistributables have not changed since Windows 8 (since Windows 10 doesn't actually need them) and Microsoft has finally started making them as standalone at: https://go.microsoft.com/fwlink/p/?LinkID=253170. * Switch our default WDK location to the default install location of the redistributable MSI.
* Also improve CI support files download
* Also improve other CI scripts and remove coverity.cmd file
* These were used to build using older version of the WDK and are no longer useful.
* Zadic and wdi-simple have too much overlap and keeping both is liability to maintain.
* When building a shared library, libtool prouces _rc.lo instead of _rc.o => Call windres directly. * Addresses part of pbatard#274. * Also fix sed's mishandling of CRLFs...
* Duplicate the Windows version lookup since we don't want to export the API. * Addresses part of pbatard#274.
* This is done to avoid symbol collision with other libraries. * Closes pbatard#274.
* And also update AUTHORS to latest.
* Requires x86 emulation on the ARM64 platform since we are not compiling native libraries or examples (only the internal installer is native). * Only WinUSB and USBSer drivers are supported. * Addresses pbatard#155.
* Also fix some whitespace issues.
* Also fix static analysis warnings
* Also synchronize safe and UTF-8 calls with what Rufus uses.
…te DLL entry * The reuse flag is meant to apply to the preceding file, and should be for the DLL and not the .exe.
* Update libusb-win32 URL to latest
* Fixes side-loading vulnerabilities reported by Sahil Shah. * Also force reproducible builds (/BREPRO) while we're at it. * Also fix copyright sign mangling in the .rc and apply other housekeeping.
Copilot created this pull request from a session on behalf of
DanTheMan827
June 8, 2026 14:57
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR pulls in the latest upstream changes from
pbatard/libwdiand updates this branch to the current project state. It also ensures ARM support is present in the merged codebase and build configuration while preserving compilation/installation compatibility expectations from the task.Upstream sync
upstream/masterintocopilot/merge-upstream-changes.ARM/ARM64 support inclusion
libwdi/libwdi.c).libwdi/.msvc/installer_arm64.vcxproj,libwdi.sln), so ARM64 artifacts are represented in the MSVC graph.Workflow security hardening (post-merge)
permissionsblocks to GitHub Actions workflows introduced/updated by the merge (coverity.yml,mingw.yml,vs2022.yml).Example (architecture mapping now present in merged core code):