Merged
Conversation
WalkthroughFeedSection.kt의 FeedItem에서 스포일러일 때 스포일러 액션 텍스트 뒤에 높이 20.dp의 Spacer를 삽입하도록 레이아웃을 변경했습니다. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@feature/feed/src/main/java/com/into/websoso/feature/feed/component/FeedSection.kt`:
- Around line 302-303: FeedSection 내 고정 Spacer(Modifier.height(10.dp)) 때문에 케이스별로
카드 상단 총 간격이 달라져 20dp 보장이 깨지므로, Spacer 높이를 조건부로 계산해 전체 상단 여백이 항상 20.dp가 되도록
변경하세요; 현재 분기 로직(스포일러, 이미지, 일반 텍스트)을 확인하고 각 분기에서 이미 추가되는 내부 여백값을 기준으로 필요한 추가 간격 =
20.dp - existingTopPadding을 계산해 Spacer 높이로 사용(최소 0.dp로 클램프)하거나 공통 함수(예:
computeTopSpacerHeight())를 만들어 FeedSection에서 호출하도록 리팩터링하여 Modifier.height(...)
호출을 대체하세요.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: e866ecbf-a0b6-4e78-aa3c-df4620e44a94
📒 Files selected for processing (1)
feature/feed/src/main/java/com/into/websoso/feature/feed/component/FeedSection.kt
Comment on lines
+302
to
+303
| Spacer(modifier = Modifier.height(height = 10.dp)) | ||
|
|
There was a problem hiding this comment.
작품 카드 상단 간격이 케이스별로 달라져 20dp 보장이 깨집니다.
Line 302의 고정 10.dp 추가로 분기별 총 간격이 달라집니다(스포일러 10dp, 이미지 20dp, 일반 텍스트 30dp). PR 목표가 “작품 연결 시 20dp”라면, 여기서는 조건부 간격 계산이 필요합니다.
제안 패치
if (feed.novel != null) {
- Spacer(modifier = Modifier.height(height = 10.dp))
+ val novelTopSpacing =
+ when {
+ feed.isSpoiler -> 20.dp
+ feed.imageUrls.isNotEmpty() -> 10.dp
+ else -> 0.dp
+ }
+ Spacer(modifier = Modifier.height(height = novelTopSpacing))
FeedNovelInfo(
novel = feed.novel,
onNovelClick = onNovelClick,
)
}🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@feature/feed/src/main/java/com/into/websoso/feature/feed/component/FeedSection.kt`
around lines 302 - 303, FeedSection 내 고정 Spacer(Modifier.height(10.dp)) 때문에
케이스별로 카드 상단 총 간격이 달라져 20dp 보장이 깨지므로, Spacer 높이를 조건부로 계산해 전체 상단 여백이 항상 20.dp가 되도록
변경하세요; 현재 분기 로직(스포일러, 이미지, 일반 텍스트)을 확인하고 각 분기에서 이미 추가되는 내부 여백값을 기준으로 필요한 추가 간격 =
20.dp - existingTopPadding을 계산해 Spacer 높이로 사용(최소 0.dp로 클램프)하거나 공통 함수(예:
computeTopSpacerHeight())를 만들어 FeedSection에서 호출하도록 리팩터링하여 Modifier.height(...)
호출을 대체하세요.
There was a problem hiding this comment.
🧹 Nitpick comments (1)
feature/feed/src/main/java/com/into/websoso/feature/feed/component/FeedSection.kt (1)
248-267: 스포일러 케이스 패딩 수정 확인됨, 이미지 케이스 간격 불일치 검토 필요스포일러 텍스트 후 20dp Spacer 추가로 issue
#838의스포일러 UI 깨짐 문제가 해결되었습니다.다만, 전체 분기별 novel 카드 상단 간격이 다릅니다:
- 스포일러: 20dp (line 256) ✓
- 일반 텍스트(이미지 없음): 20dp (line 267) ✓
- 이미지 포함: 10dp (line 299) — 불일치
이미지가 있는 경우에도 20dp 간격이 필요하다면 추후 수정을 검토해 주세요.
♻️ 이미지 케이스도 20dp 통일 시 제안 패치
} - Spacer(modifier = Modifier.height(height = 10.dp)) + Spacer(modifier = Modifier.height(height = 20.dp)) } }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@feature/feed/src/main/java/com/into/websoso/feature/feed/component/FeedSection.kt` around lines 248 - 267, The top spacing for the branch that renders feeds with images is inconsistent (10.dp) compared to the spoiler and plain-text branches (20.dp); update the Spacer used in the image-containing rendering path to use Modifier.height(20.dp) so all branches (including the image branch in FeedSection.kt) use 20.dp top spacing—locate the Spacer after the image rendering block (the same area that calls onContentClick(feed.id, feed.isLiked) and adjust its height to 20.dp.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In
`@feature/feed/src/main/java/com/into/websoso/feature/feed/component/FeedSection.kt`:
- Around line 248-267: The top spacing for the branch that renders feeds with
images is inconsistent (10.dp) compared to the spoiler and plain-text branches
(20.dp); update the Spacer used in the image-containing rendering path to use
Modifier.height(20.dp) so all branches (including the image branch in
FeedSection.kt) use 20.dp top spacing—locate the Spacer after the image
rendering block (the same area that calls onContentClick(feed.id, feed.isLiked)
and adjust its height to 20.dp.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 71238fc6-1124-437d-b5b1-aef5cf278bbf
📒 Files selected for processing (1)
feature/feed/src/main/java/com/into/websoso/feature/feed/component/FeedSection.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌𝘐𝘴𝘴𝘶𝘦𝘴
📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯
📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵
💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴
830번 이슈 고칠 시 누락됬던 것이라 수정했습니다.
Summary by CodeRabbit