Skip to content

chore: rebuild README.md and config.json#418

Open
lbzepoqo wants to merge 2 commits intoTeam-Silver-Sphere:masterfrom
lbzepoqo:chore/rebuild-docs
Open

chore: rebuild README.md and config.json#418
lbzepoqo wants to merge 2 commits intoTeam-Silver-Sphere:masterfrom
lbzepoqo:chore/rebuild-docs

Conversation

@lbzepoqo
Copy link
Copy Markdown
Contributor

Summary

  • Regenerates README.md and config.json via yarn build-all
  • Pure ordering/formatting diff — no content changes to any plugin documentation
  • Separates the docs regeneration from plugin-specific PRs to keep histories clean

Test plan

  • Verify no plugin documentation content was added or removed
  • Confirm yarn build-all produces no further diff after merging

@lbzepoqo lbzepoqo requested a review from werewolfboy13 as a code owner April 16, 2026 07:35
@fantinodavide
Copy link
Copy Markdown
Contributor

@lbzepoqo I believe the issue should be resolved at the root, adding a proper sorting in the methods that do the actual generation of the config.json file in https://github.com/Team-Silver-Sphere/SquadJS/blob/master/squad-server/factory.js

The sort comparators in buildConfig() and buildReadmeFile() were comparing
a.name and b.name, but Object.keys() returns strings — not plugin objects.
.name on a string is undefined, making the sort a no-op. Fix by comparing
the key strings directly, then regenerate docs with deterministic ordering.
@lbzepoqo
Copy link
Copy Markdown
Contributor Author

Fixed in 938f70c. The sort comparators in both buildConfig() and buildReadmeFile() were comparing a.name / b.name — but Object.keys() returns strings, not plugin objects, so .name was always undefined and the sort was a no-op. Changed to compare the key strings directly (a < b), then regenerated docs with the now-deterministic ordering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants