Skip to content

temp: Architectural Rework of Flex Nodes #1736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
camielvs wants to merge 1 commit into from
Closed

temp: Architectural Rework of Flex Nodes #1736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 4 additions & 17 deletions src/components/shared/ReactFlow/FlowCanvas/FlexNode/FlexNode.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,17 @@
import { type Node, type NodeProps } from "@xyflow/react";
import { useEffect } from "react";

import { InfoBox } from "@/components/shared/InfoBox";
import { Paragraph } from "@/components/ui/typography";
import { cn } from "@/lib/utils";
import { useContextPanel } from "@/providers/ContextPanelProvider";

import { StickyNoteEditor } from "./StickyNoteEditor";
import { FlexNodeEditor } from "./FlexNodeEditor";
import type { FlexNodeData } from "./types";

type FlexNodeProps = NodeProps<Node<FlexNodeData>>;

const FlexNode = ({ data, id, selected }: FlexNodeProps) => {
const { properties, readOnly, type } = data;
const { properties, readOnly } = data;
const { color, zIndex } = properties;

const {
Expand All @@ -23,19 +22,7 @@ const FlexNode = ({ data, id, selected }: FlexNodeProps) => {

useEffect(() => {
if (selected) {
switch (type) {
case "sticky-note":
setContent(
<StickyNoteEditor stickyNote={data} readOnly={readOnly} />,
);
break;
default:
setContent(
<InfoBox title="Context Panel Error" variant="error">
Unknown node type: <span className="font-mono">{type}</span>
</InfoBox>,
);
}
setContent(<FlexNodeEditor flexNode={data} readOnly={readOnly} />);
setContextPanelOpen(true);
}

Expand All @@ -44,7 +31,7 @@ const FlexNode = ({ data, id, selected }: FlexNodeProps) => {
clearContent();
}
};
}, [selected]);
}, [data, readOnly, selected]);

return (
<div
Expand Down
12 changes: 6 additions & 6 deletions .../FlowCanvas/FlexNode/StickyNoteEditor.tsx → ...ow/FlowCanvas/FlexNode/FlexNodeEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,16 @@ import { Paragraph, Text } from "@/components/ui/typography";

import type { FlexNodeData } from "./types";

interface StickyNoteEditorProps {
stickyNote: FlexNodeData;
interface FlexNodeEditorProps {
flexNode: FlexNodeData;
readOnly?: boolean;
}

export const StickyNoteEditor = ({
stickyNote,
export const FlexNodeEditor = ({
flexNode,
readOnly = false,
}: StickyNoteEditorProps) => {
const { properties, size, position } = stickyNote;
}: FlexNodeEditorProps) => {
const { properties, size, position } = flexNode;

return (
<BlockStack gap="4" className="h-full px-2">
Expand Down