forked from Cloud-Pipelines/pipeline-editor
-
Notifications
You must be signed in to change notification settings - Fork 5
chore: Node Definition Cleanup #1731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
camielvs
wants to merge
1
commit into
master
Choose a base branch
from
01-30-chore_node_definition_cleanup
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
3 tasks
2c2d8ab to
8dca03b
Compare
4368a59 to
3afbeb3
Compare
3 tasks
8dca03b to
f0ac49b
Compare
This was referenced Feb 3, 2026
f0ac49b to
d8bc666
Compare
This was referenced Feb 3, 2026
d8bc666 to
47ebeb8
Compare
This was referenced Feb 3, 2026
31dfecb to
851a7d9
Compare
This was referenced Feb 4, 2026
851a7d9 to
8b7dbf9
Compare
3 tasks
e547e8d to
c656456
Compare
f064cca to
e457cec
Compare
e457cec to
b255032
Compare
This was referenced Feb 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Description
Moves around a bit of code - particularly for Node Definition and types in React Flow - to standardise and tidy things in advance of Flex (sticky note) Nodes.
This includes the explicit provision of
readOnlymode to created nodes (flex nodes will make use of this).Also moves the Common Annotations list fallback to a more suitable location (to avoid flaky circular dependencies). And fixes a typo in
buildTaskSpecShape.No change to UI.
Related Issue and Pull requests
Type of Change
Checklist
Screenshots (if applicable)
Test Instructions
Confirm the app still works as expected.
Additional Comments