Skip to content

Conversation

@camielvs
Copy link
Collaborator

@camielvs camielvs commented Jan 30, 2026

Description

Moves around a bit of code - particularly for Node Definition and types in React Flow - to standardise and tidy things in advance of Flex (sticky note) Nodes.

This includes the explicit provision of readOnly mode to created nodes (flex nodes will make use of this).

Also moves the Common Annotations list fallback to a more suitable location (to avoid flaky circular dependencies). And fixes a typo in buildTaskSpecShape.

No change to UI.

Related Issue and Pull requests

Type of Change

  • Cleanup/Refactor

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

Confirm the app still works as expected.

Additional Comments

@camielvs camielvs mentioned this pull request Jan 30, 2026
3 tasks
Copy link
Collaborator Author

camielvs commented Jan 30, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camielvs camielvs mentioned this pull request Jan 30, 2026
3 tasks
@camielvs camielvs changed the base branch from 01-30-feat_add_basic_flexnode to graphite-base/1731 February 2, 2026 19:05
@camielvs camielvs force-pushed the 01-30-chore_node_definition_cleanup branch from 2c2d8ab to 8dca03b Compare February 2, 2026 19:06
@camielvs camielvs changed the base branch from graphite-base/1731 to master February 2, 2026 19:06
@camielvs camielvs mentioned this pull request Feb 2, 2026
3 tasks
@camielvs camielvs force-pushed the 01-30-chore_node_definition_cleanup branch from 8dca03b to f0ac49b Compare February 2, 2026 21:30
@camielvs camielvs force-pushed the 01-30-chore_node_definition_cleanup branch from f0ac49b to d8bc666 Compare February 3, 2026 22:36
@camielvs camielvs force-pushed the 01-30-chore_node_definition_cleanup branch from d8bc666 to 47ebeb8 Compare February 3, 2026 23:32
@camielvs camielvs force-pushed the 01-30-chore_node_definition_cleanup branch 2 times, most recently from 31dfecb to 851a7d9 Compare February 4, 2026 19:05
@camielvs camielvs force-pushed the 01-30-chore_node_definition_cleanup branch from 851a7d9 to 8b7dbf9 Compare February 5, 2026 21:42
@camielvs camielvs force-pushed the 01-30-chore_node_definition_cleanup branch 2 times, most recently from e547e8d to c656456 Compare February 6, 2026 16:07
@camielvs camielvs force-pushed the 01-30-chore_node_definition_cleanup branch 6 times, most recently from f064cca to e457cec Compare February 6, 2026 23:09
@camielvs camielvs force-pushed the 01-30-chore_node_definition_cleanup branch from e457cec to b255032 Compare February 6, 2026 23:17
@camielvs camielvs marked this pull request as ready for review February 6, 2026 23:34
@camielvs camielvs requested a review from a team as a code owner February 6, 2026 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant