Skip to content

Annotation Filter input#1706

Draft
Mbeaulne wants to merge 1 commit into01-27-date_pickerfrom
01-27-annotation_filter_input
Draft

Annotation Filter input#1706
Mbeaulne wants to merge 1 commit into01-27-date_pickerfrom
01-27-annotation_filter_input

Conversation

@Mbeaulne
Copy link
Collaborator

@Mbeaulne Mbeaulne commented Jan 27, 2026

Resolves: https://github.com/Shopify/oasis-frontend/issues/458

Description

Adds an annotation filter input component for filtering pipeline runs by key-value annotation pairs.

Note: This is a UI-only preview. The filters update the URL but are not properly connected to the API, causing a broken search state. This is resolved in a later PR in the stack.

Type of Change

  • New feature

Changes

  • Added AnnotationFilterInput component with:
    • Add annotation filters with key and optional value
    • Inline editing of existing filters (double-click to edit)
    • Remove filters with X button
    • Keyboard support (Enter to add/save, Escape to cancel)
  • Integrated annotation filters into PipelineRunFiltersBar

Checklist

  • I have tested this does not break current pipelines/runs functionality

Test Instructions

  1. Enable the feature flag: Settings → Beta → "Pipeline run filters bar (UI only)"
  2. Navigate to the Runs tab on the home page
  3. Click "Add filter" in the Annotations row
  4. Enter a key and optional value, press Enter or click Add
  5. Double-click a badge to edit, click X to remove

Copy link
Collaborator Author

Mbeaulne commented Jan 27, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Mbeaulne Mbeaulne mentioned this pull request Jan 27, 2026
2 tasks
@Mbeaulne Mbeaulne force-pushed the 01-27-annotation_filter_input branch from 702e058 to 055a218 Compare January 27, 2026 15:48
This was referenced Jan 27, 2026
@Mbeaulne Mbeaulne force-pushed the 01-27-annotation_filter_input branch from 055a218 to aeda0ef Compare January 27, 2026 15:59
@Mbeaulne Mbeaulne force-pushed the 01-27-annotation_filter_input branch 3 times, most recently from 185fc8e to d548dd0 Compare January 27, 2026 16:39
@Mbeaulne Mbeaulne force-pushed the 01-27-annotation_filter_input branch from d548dd0 to 57641b0 Compare January 27, 2026 18:57
@Mbeaulne Mbeaulne force-pushed the 01-27-annotation_filter_input branch from 57641b0 to 60e5301 Compare January 28, 2026 20:46
@Mbeaulne Mbeaulne force-pushed the 01-27-annotation_filter_input branch 3 times, most recently from a4e2ef4 to e9ccb7d Compare February 2, 2026 20:31
@Mbeaulne Mbeaulne force-pushed the 01-27-annotation_filter_input branch 2 times, most recently from f74981d to fbe5916 Compare February 2, 2026 21:08
@Mbeaulne Mbeaulne force-pushed the 01-27-date_picker branch 2 times, most recently from 713cdad to 7e04972 Compare February 2, 2026 21:10
@Mbeaulne Mbeaulne force-pushed the 01-27-annotation_filter_input branch from fbe5916 to 40b0fda Compare February 2, 2026 21:10
@Mbeaulne Mbeaulne force-pushed the 01-27-annotation_filter_input branch from 40b0fda to dcba6f7 Compare February 2, 2026 21:14
@Mbeaulne Mbeaulne force-pushed the 01-27-annotation_filter_input branch 2 times, most recently from a7c0dd7 to 04bf191 Compare February 2, 2026 21:50
@Mbeaulne Mbeaulne force-pushed the 01-27-annotation_filter_input branch from 04bf191 to efa98af Compare February 2, 2026 22:04
@Mbeaulne Mbeaulne force-pushed the 01-27-date_picker branch 2 times, most recently from f7fe314 to deb94c7 Compare February 2, 2026 22:09
@Mbeaulne Mbeaulne force-pushed the 01-27-annotation_filter_input branch 2 times, most recently from cdf6cd4 to 9f01605 Compare February 2, 2026 22:19
@Mbeaulne Mbeaulne force-pushed the 01-27-date_picker branch 2 times, most recently from 746eb8f to f449f7f Compare February 3, 2026 16:32
@Mbeaulne Mbeaulne force-pushed the 01-27-annotation_filter_input branch 2 times, most recently from b7642fc to b61c598 Compare February 3, 2026 16:42
@Mbeaulne Mbeaulne force-pushed the 01-27-annotation_filter_input branch from b61c598 to c9f551d Compare February 3, 2026 16:58
@Mbeaulne Mbeaulne force-pushed the 01-27-date_picker branch 2 times, most recently from b01e095 to fb7cd6f Compare February 3, 2026 17:49
@Mbeaulne Mbeaulne force-pushed the 01-27-annotation_filter_input branch from c9f551d to b2505d1 Compare February 3, 2026 17:49
@Mbeaulne Mbeaulne force-pushed the 01-27-annotation_filter_input branch from b2505d1 to 56d7d09 Compare February 3, 2026 17:56
@Mbeaulne Mbeaulne force-pushed the 01-27-annotation_filter_input branch from 56d7d09 to c370fa6 Compare February 3, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant